Skip to content

Commit

Permalink
test: Disable TLS 1.3 in one test
Browse files Browse the repository at this point in the history
This test started failing on windows CI with an upgrade to python
3.7.4 (which bundles a newer version of openssl). Disable tls 1.3 for
now.

Possibly related to tornadoweb#2536
  • Loading branch information
bdarnell committed Mar 3, 2020
1 parent 4c2160c commit 44d65de
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions tornado/test/iostream_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1037,9 +1037,16 @@ def connect_to_server(self, server_cls):
server = server_cls(ssl_options=_server_ssl_options())
server.add_socket(sock)

client = SSLIOStream(
socket.socket(), ssl_options=dict(cert_reqs=ssl.CERT_NONE)
)
ssl_ctx = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)
ssl_ctx.check_hostname = False
ssl_ctx.verify_mode = ssl.CERT_NONE
# These tests fail with ConnectionAbortedErrors with TLS
# 1.3 on windows python 3.7.4 (which includes an upgrade
# to openssl 1.1.c. Other platforms might be affected with
# newer openssl too). Disable it until we figure out
# what's up.
ssl_ctx.options |= getattr(ssl, "OP_NO_TLSv1_3", 0)
client = SSLIOStream(socket.socket(), ssl_options=ssl_ctx)
yield client.connect(("127.0.0.1", port))
self.assertIsNotNone(client.socket.cipher())
finally:
Expand Down

0 comments on commit 44d65de

Please sign in to comment.