feat: Add geoclue.timeout option #145
Merged
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 80.13% 80.18% +0.04%
==========================================
Files 21 21
Lines 1208 1216 +8
==========================================
+ Hits 968 975 +7
- Misses 240 241 +1 ☔ View full report in Codecov by Sentry. |
RyanGibb
reviewed
Jan 23, 2025
| @@ -46,6 +46,15 @@ in { | |||
| default = false; | |||
| description = "Prefer GeoClue 2 over manual location configuration."; | |||
| }; | |||
| timeout = lib.mkOption { | |||
| type = lib.types.int; | |||
There was a problem hiding this comment.
Just a small observation that this could be changed to with lib.types; nullOr path; to support using the default value.
Thanks for the update!
There was a problem hiding this comment.
Of course. The idea was actually to explicitly define the default value. Fixed in cbdf135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.