-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatic location retrieval using geoclue2 #141
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 88.36% 82.46% -5.91%
==========================================
Files 18 19 +1
Lines 1006 1089 +83
==========================================
+ Hits 889 898 +9
- Misses 117 191 +74 ☔ View full report in Codecov by Sentry. |
I can confirm that it works! Geoclue wasn't working due to NixOS/nixpkgs#321121 (fixed by using https://beacondb.net/). I wasn't getting any error message explicitly saying geoclue had failed about this (with debug logs on) but maybe I should have with this bail? I also think it might be worth mentioning that you need to configure geoclue to allow timewall to connect with the id defined here. E.g. on NixOS I think it's:
|
Did you use
This is interesting because I actually didn't have to configure this (I'm on NixOS too). Still, I added this to the README, I guess this might depend on the environment. |
No description provided.