Remove rimraf devdep

[bcomnes]

Remove rimraf as a dev dep. One less thing to update.

[voxpelli]

As long as the tests still pass on Windows I’m 🙌

[TWiStErRob]

Hmm, I have a feeling that the docs should keep the rimraf there so the "recommendation" is to support multiplatform builds?

[bcomnes]

I know github action windows runners support rm -rf directly now, is that a gha specific feature?

Alternatively could we instead recommend windows users use wsl for multiplatform builds?

My goal is to eliminate random one off solutions like rimraf when there are better platform solutions available now.

[TWiStErRob]

I'm not sure it's GHA only. I'll check what's available to confirm if this actually affects pure Windows (non-WSL) developer machines.

[XhmikosR]

FYI this breaks native Windows cmd and requires a unix environment, so WSL, MSYS, etc.

[bcomnes]

Wsl should work. Posh has rm -rf now right? Git bash is also a good option on windows. GitHub action windows runners have rm -rf now. Besides this is just used in testing and docs, people are free to use rimraf as needed. I just don't want to keep updating this dep since it doesn't seem that critical here.

[voxpelli]

@XhmikosR Do you know how this can be the case then?

I know github action windows runners support rm -rf directly now, is that a gha specific feature?

Are GitHub:s runners not representative of a normal windows box? Does it run a different version of windows to what you do?

Unless there’s a way to test and verify that it works or break then it’s hard to know

[XhmikosR]

@voxpelli the default is to use bash even on Windows, hence why this doesn't fail on CI. So, no, it's not default regarding the shell. But believe me, it does fail on Windows native cmd :)

[voxpelli]

That’s weird and unexpected :/ Then one can’t trust those tests really

[XhmikosR]

There's a reason behind this decision, as always. But this doesn't change the thing that this change breaks things on Windows native cmd. If you guys consider it important, that's another thing. I personally strive to keep Windows compatibility all these years, but either decision is OK since this doesn't seem to affect the end users.

…

On Thu, Oct 24, 2024, 18:28 Pelle Wessman ***@***.***> wrote: That’s weird and unexpected :/ Then one can’t trust those tests really — Reply to this email directly, view it on GitHub <#156 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNPRSR5DILK46K2EHTLZ5EG3DAVCNFSM6AAAAABQFDL4LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGYYTAMBZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[voxpelli]

As long as the tests still pass on Windows I’m 🙌

I mean, this was my review comment @XhmikosR

[bcomnes]

As a windows user worried about compatibility, it seems like wsl would be the better solution to this and for many of the other edge cases similar to this. Is this not accessible by default for some reason? (Sorry I haven't run windows in years).

Also, as a dev time only dep, you would also need access to git, which would also seem to necessitate wsl or git bash.

My goal is to cut down on everywhere deps when there are better solutions available because I get like 50+ prs when they major version.

[voxpelli]

@XhmikosR That bash is the default on windows seems to be incorrect? The documentation says that this is the default:

Windows pwsh

This is the default shell used on Windows. The PowerShell Core. GitHub appends the extension .ps1 to your script name. If your self-hosted Windows runner does not have PowerShell Core installed, then PowerShell Desktop is used instead.

pwsh -command ". '{0}'".

---

@bcomnes If you make a config like I did here you can opt to ignore such automated PR:s for specific dependencies: https://github.com/voxpelli/renovate-config/blob/main/ignores.json

---

Maybe we should restore some note in the docs? I'm okay with keeping the npm scripts as they are

[voxpelli]

@bcomnes I wonder if it would be useful to run the CI tests in more of the shells available: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell

[voxpelli]

This is what rimraf itself uses to run its tests: https://github.com/isaacs/rimraf/blob/8733d4c30078a1ae5f18bb6affe83c1eea0259b4/.github/workflows/ci.yml#L15-L18

        node-version: [20.x, 22.x]
        platform:
        - os: ubuntu-latest
          shell: bash
        - os: macos-latest
          shell: bash
        - os: windows-latest
          shell: bash
        - os: windows-latest
          shell: powershell