Remove sanitize from Crate constructor #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bcollazo -- this is a fantastic library!
The sanitize method you're using when creating new Crate objects breaks subcrates, which are formatted with
%%as an indicator of nesting (e.g.NOSTALGIA FACTORY%%1950's.cratewhere 1950's is nested under NOSTALGIA FACTORY).I heavily use subcrates and this library was unable to access / manage my subcrates. Curious what issues caused the need for sanitize? Or if it was just a precaution?
If the latter, removing sanitize provides additional functionality for this library.
FYI - I'm using your library in a cli util to programmatically update file paths for my entire library.