Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PyPi versions work #192

Merged
merged 6 commits into from
Jul 17, 2022
Merged

Ensure PyPi versions work #192

merged 6 commits into from
Jul 17, 2022

Conversation

bcollazo
Copy link
Owner

@bcollazo bcollazo commented Jul 17, 2022

It seems Gym 0.25 now uses "render_modes" instead of "render.modes" which was yielding this error: #55 (comment).

Quick fix here is to add a CI check that ensures at least standalone catanatron-gym is installable and usable, and to lock the required gym to gym==0.21.0.

@coveralls
Copy link

coveralls commented Jul 17, 2022

Pull Request Test Coverage Report for Build 2687185135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.54%

Totals Coverage Status
Change from base Build 2687140997: 0.0%
Covered Lines: 1264
Relevant Lines: 1323

💛 - Coveralls

@bcollazo bcollazo temporarily deployed to catanatron-bryan-pypi-qb7dncwo July 17, 2022 22:56 Inactive
@bcollazo bcollazo temporarily deployed to catanatron-bryan-pypi-qb7dncwo July 17, 2022 22:57 Inactive
@bcollazo bcollazo merged commit 87c4aec into master Jul 17, 2022
@bcollazo bcollazo deleted the bryan/pypi branch July 17, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants