Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ignoring lines, functions, and blocks #87

Merged
merged 3 commits into from
May 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 35 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,47 @@ To check thresholds on a per-file basis run:
c8 check-coverage --lines 95 --per-file
```

## Ignoring Uncovered Lines, Functions, and Blocks

Sometimes you might find yourself wanting to ignore uncovered portions of your
codebase. For example, perhaps you run your tests on Linux, but
there's some logic that only executes on Windows.

To ignore lines, blocks, and functions, use the special comment:

`/* c8 ignore next */`.

### Ignoring the next element

```js
const myVariable = 99
/* c8 ignore next */
if (process.platform === 'win32') console.info('hello world')
```

### Ignoring the next N elements

```js
const myVariable = 99
/* c8 ignore next 3 */
if (process.platform === 'win32') {
console.info('hello world')
}
```

### Ignoring a block on the current line

```js
const myVariable = 99
const os = process.platform === 'darwin' ? 'OSXy' /* c8 ignore next */ : 'Windowsy'
```

## Supported Node.js Versions

c8 uses
[bleeding edge Node.js features](https://github.com/nodejs/node/pull/22527),
make sure you're running Node.js `>= 10.12.0`.

## Goals of the Project

A fully functional code coverage solution using only V8's native coverage
features and minimal user-land modules, so that we fit these constraints:

* No parsing of JavaScript code.
* No mucking with Node.js' runtime environment.

## Contributing to `c8`

See the [contributing guide here](./CONTRIBUTING.md).
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"istanbul-reports": "^2.0.0",
"rimraf": "^2.6.2",
"test-exclude": "^5.0.0",
"v8-to-istanbul": "^3.0.1",
"v8-to-istanbul": "^3.1.1",
"yargs": "^13.1.0",
"yargs-parser": "^10.1.0"
},
Expand Down
22 changes: 22 additions & 0 deletions test/fixtures/c8-ignore-next.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
const a = 99
const b = true ? 1 /* c8 ignore next */ : 2
if (true) {
console.info('covered')
/* c8 ignore next 3 */
} else {
console.info('uncovered')
}

/* c8 ignore next */
if (false) console.info('uncovered')

/* c8 ignore next 3 */
function notExecuted () {

}

if (true) {
console.info('covered')
} else { /* c8 ignore next */
console.info('uncovered')
}
14 changes: 14 additions & 0 deletions test/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,20 @@ describe('c8', () => {
})
})

describe('/* c8 ignore next */', () => {
it('ignores lines with special comment', () => {
const { output } = spawnSync(nodePath, [
c8Path,
'--exclude="test/*.js"',
'--clean=false',
'--temp-directory=tmp/normal',
nodePath,
require.resolve('./fixtures/c8-ignore-next.js')
])
output.toString('utf8').should.matchSnapshot()
})
})

describe('source-maps', () => {
beforeEach(cb => rimraf('tmp/source-map', cb))

Expand Down
14 changes: 14 additions & 0 deletions test/integration.js.snap
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`c8 /* c8 ignore next */ ignores lines with special comment 1`] = `
",covered
covered
-------------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
-------------------|----------|----------|----------|----------|-------------------|
All files | 86.21 | 91.67 | 66.67 | 86.21 | |
async.js | 100 | 100 | 100 | 100 | |
c8-ignore-next.js | 90.91 | 100 | 100 | 90.91 | 21,22 |
normal.js | 75 | 66.67 | 33.33 | 75 | 14,15,16,18,19,20 |
-------------------|----------|----------|----------|----------|-------------------|
,"
`;

exports[`c8 ESM Modules collects coverage for ESM modules 1`] = `
",bar foo
------------|----------|----------|----------|----------|-------------------|
Expand Down