-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fun: switch to async IO #9
Comments
@bcoe what do you think about typescript? :) |
@Bnaya 👋I'm not a huge advocate of Typescript; part of why I'm excited about native coverage support in v8 is that it can eliminate some of the transpilation that is currently being performed by Istanbul. But! I would love your help on c8; if you'd like to contribute, strike up a conversation with me in this Slack: |
@bcoe - would like to take up this one (for fun :)). I can't seem to get the code that is being referred here:
in Do we also change the |
@profnandaa I'd have a preference with just using the new I think we could switch everything that's blocking to |
@bcoe -- I'll be on it, hopefully should raise the PR tomorrow (going to bed now). Thanks for the heads-up about the Mozilla project, checking it out 👍 |
- Replace mkdirp with the new fs.mkdir with `recursive` option - Rewrite all top level IO to async (mkdir and rimraf) Remaining work: to rewrite lib/*.js to async I/O Ref: bcoe#9
- Replace mkdirp with the new fs.mkdir with `recursive` option - Rewrite all top level IO to async (mkdir and rimraf) Remaining work: to rewrite lib/*.js to async I/O Ref: #9
@profnandaa thank you for this contribution. |
c8 already requires a bleeding edge v8 engine, we should switch to
async
/await
rather than using any synchronous IO.see @TimothyGu's comments in #8.
The text was updated successfully, but these errors were encountered: