This repository has been archived by the owner on Dec 9, 2020. It is now read-only.
Display temp & RH in graph for each station #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Button story * Separate theme obj from App.tsx
from "forecast" to "model" from "actual" to "reading
Kyubinhan
changed the title
Sybrand
reviewed
May 28, 2020
| // Theme documentation: https://material-ui.com/customization/palette/ | ||
| // Theme demo: https://material.io/resources/color/#!/?view.left=1&view.right=1&primary.color=003365&secondary.color=FBC02D | ||
| // Do not export this directly! theme should be accessed within makeStyles & withStyles. Use ErrorMessage.tsx as a reference | ||
| export const theme = createMuiTheme({ |
There was a problem hiding this comment.
The comment says not to export?
There was a problem hiding this comment.
Yeah, I had to make it exportable so that I can use the same theme in Storybook .storybook/decorators/ThemeDecorator.tsx. I will change the wording to Do not export this directly for styling!
| @@ -7,7 +7,7 @@ WORKDIR /app | |||
| COPY package*.json ./ | |||
|
|
|||
| ## Install only the packages defined in the package-lock.json (faster than the normal npm install) | |||
| RUN npm set progress=false && npm ci --production | |||
| RUN npm set progress=false && npm ci --no-cache | |||
There was a problem hiding this comment.
Don't we rather want?
Suggested change
| RUN npm set progress=false && npm ci --no-cache | |
| RUN npm set progress=false && npm ci --no-cache --production |
| "typescript": "^3.7.5" | ||
| }, | ||
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "start": "CI=true react-scripts start", |
There was a problem hiding this comment.
Not exactly sure what it does but it fixes the issue where it fails to start in the docker container.
facebook/create-react-app#8688 (comment)
Sybrand
approved these changes
May 28, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.