Add dev TDW server values #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
esune
requested changes
Oct 9, 2024
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
esune
reviewed
Oct 11, 2024
Comment on lines
12
to
13
| repository: image-registry.openshift-image-registry.svc:5000/4a9599-tools/tdw-server | ||
| tag: latest |
There was a problem hiding this comment.
I forgot to pluck this out - we should be able to remove and just use what is defined in the default values.yaml (this was just so we could test changes without the need for a new release). Do you mind removing the repository/tag reference @PatStLouis ?
Signed-off-by: pstlouis <[email protected]>
esune
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.