Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proof-configuration for BC Wallet Showcase Person for development purposes. #187

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

esune
Copy link
Member

@esune esune commented Mar 13, 2024

Added a proof-configuration that matches the credentials issued by the BC Wallet Showcase (dev/test/prod) for development and prototyping purposes (the SSO team will be using it).

The proof configuration was already installed in VC-AuthN

@esune esune requested a review from WadeBarnes March 13, 2024 20:19
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a note somewhere that these are all rooted on BCovrin Test?

Should the version of the schema be specified? There is Person v1.1, and v1.2, v1.2 is the only version that exists for all three DIDs? Both versions seem to contain the same attributes.

@esune
Copy link
Member Author

esune commented Mar 13, 2024

Should there be a note somewhere that these are all rooted on BCovrin Test?

Should the version of the schema be specified? There is Person v1.1, and v1.2, v1.2 is the only version that exists for all three DIDs.

Good questions.

Regarding the schema: I left it purposely open in order to allow newer version to work without intervention since it is just for development.

Regarding the note on BCovrin: VC-AuthN is configured to also support BCovrin Test out of the box for dev/test, wondering if leaving it under the dev folder is good enough, or you see a specific reason to call this out.

@WadeBarnes
Copy link
Member

WadeBarnes commented Mar 13, 2024

Regarding the schema: I left it purposely open in order to allow newer version to work without intervention since it is just for development.

Sounds like a good plan.

Regarding the note on BCovrin: VC-AuthN is configured to also support BCovrin Test out of the box for dev/test, wondering if leaving it under the dev folder is good enough, or you see a specific reason to call this out.

I was thinking more for the benefit of someone looking at the proof request and searching the ledgers for the related dids/schemas. My initial assumption, which was incorrect, was to look at the CANdy ledgers.

@esune
Copy link
Member Author

esune commented Mar 13, 2024

I was thinking more for the benefit of someone looking at the proof request and searching the ledgers for the related dids/schemas. My initial assumption, which was incorrect, was to look at the CANdy ledgers.

Gotcha. I wonder if we should tackle this as part of the work to complete openwallet-foundation/acapy-vc-authn-oidc#435 : this would add the possibility to add metadata to a proof-configuration, where information about the root ledger could be stored (e.g.: add support for metadata, update configurations here to include extra information).

@WadeBarnes WadeBarnes merged commit da5be89 into bcgov:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants