-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Multiple Ledger and Endorser Selection + additional UI Controls #790
Conversation
shaangill025
commented
Sep 5, 2023
- resolve Select which Ledger/Endorser to connect to - Tenant UI #681
Re the bug discovered that is preventing transaction from being completed when switching ledger/endorser after initial selection. I believe that no further changes would be needed in Traction and only ACA-Py bug to be fixed. ACA-Py issue: openwallet-foundation/acapy#2473 |
Deployment URLs ready for review. |
@shaangill025 @esune wondering if we'd need to wait merging this before the ACA-Py issue Shaanjot has found gets completed? Or would this be independant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tested out existing behaviour with BCovrin-test here on this PR and it's working.
Could not connect to -dev
at this point but I think we discussed that.
Minor UI, don't think we need the search and filter for the ledgers here (won't be pages of them), so we can slim things down a bit?
If so, added some comments on places things could be removed. Think I got them all but not sure.
Also had merged a Traction 0.10.1 update earlier so you might find some merge conflicts FYI around the same things for that.
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/PublicDid.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/PublicDid.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/PublicDid.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/Endorser.vue
Outdated
Show resolved
Hide resolved
services/tenant-ui/frontend/src/components/profile/issuance/PublicDid.vue
Show resolved
Hide resolved
@shaangill025 other than @loneil 's comments, there's merge conflicts that require attention |
…ase related changes Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
a244830
to
1634cfc
Compare
@shaangill025 there are conflicts that need resolving. |
Sure, will test out under current bcovrin-test state after any conflicts resolved and next update. |
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This issue is unrelated to the changes @shaangill025 has made, we're seen this with other tenants in our Either way, I logged an issue to track this specific problem: bcgov/DITP#62 |
It's reproducible from what I can see. New tenant, create new schema and def, get tails error, can't accept. |
Needs fix from openwallet-foundation/acapy#2482 included in 0.10.2 (not related to other 0.10.1 issue affecting some single tenant aca-py instances) until this can be merged. |
We could use the latest nightly to test out without waiting. |
I will update to use |
Signed-off-by: Shaanjot Gill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can issue and revoke revocable creds now
On the Python lib update, is updating pyproject.toml sufficient, or should the poetry.lock
file be done as well?
When I did other ACA-Py updates I would run poetry update
in the dev contianer setup Sherman made and that would update the locks as well.
(I'm not super sure about Poetry stuff myself so not sure if it makes a difference?)
Signed-off-by: Lucas ONeil <[email protected]>
Probably next question for @esune if we'd want to merge this since it's looking like it's working with the rc0. Or if 0.10.2 is imminent just wait for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on current bcovrin-test case. As discussed, future changes coming down for other Endorser flows.
Just pending question about whether to use rc0 here or need next full aca-py release.