Allow the reservation email frontend to be blank #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
feature/allowBlankReservationEmail
branch
from
f6ecf36 to
763e3f5
Compare
Deployment URLs ready for review. |
This was referenced Feb 20, 2024
esune
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenant UI configuration for whether the reservation Email is mandatory or not. To support us allowing Sandbox Tenants to provide no email on tenant creation.
The backend has the contact email as mandatory, so went with Stephen's idea of just posting a dummy email address to keep the changes scoped to frontend. (could pull into plugin as well if we don't think this is acceptable)
If the Tenant UI is set to allow blank emails, will just post
[email protected](https://en.wikipedia.org/wiki/Example.com) as the contact email if it's left blank. Keep email format validation though if they do provide something.Will need Traction release for code and Helm release for config mapping that can coincide with values PR here bcgov/trust-over-ip-configurations#184 to affect the Sandbox env.