Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the backup container process #350

Merged
merged 17 commits into from
May 7, 2024
Merged

Conversation

thegentlemanphysicist
Copy link
Contributor

No description provided.

@thegentlemanphysicist thegentlemanphysicist marked this pull request as ready for review May 6, 2024 18:19
@thegentlemanphysicist thegentlemanphysicist added the enhancement New feature or request label May 6, 2024
Copy link
Contributor

@jlangy jlangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just left one question out of curiosity

@@ -9,7 +9,7 @@ WORKDIR /
# Load the backup scripts into the container (must be executable).
COPY backup.* /

COPY webhook-template.json /
# COPY webhook-template.json /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess their image has a template built in so we don't need this anymore?

@thegentlemanphysicist thegentlemanphysicist merged commit 844940b into dev May 7, 2024
3 checks passed
@thegentlemanphysicist thegentlemanphysicist deleted the SSOTEAM-1695 branch May 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants