Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Layer: Updates #29

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Core Layer: Updates #29

merged 6 commits into from
Oct 22, 2024

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Oct 21, 2024 •
edited
Loading

  • fix error when resetPiniaStores util called on a store without a $reset function
  • add actions prop to PageSection component and props to change heading class
  • add italic option to i18n helper component
  • update login/logout to redirect to location.href instead of location.origin
Screenshot 2024-10-21 at 12 02 13 PM

@deetz99 deetz99 self-assigned this Oct 21, 2024
kialj876
kialj876 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@deetz99 deetz99 merged commit 5928cc0 into bcgov:main Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kialj876 kialj876 kialj876 approved these changes

@thorwolpert thorwolpert thorwolpert approved these changes

Assignees

@deetz99 deetz99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deetz99 @thorwolpert @kialj876