Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25281 - Updated .env.example to use new BRD domain #3209

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

JazzarKarim
Copy link
Collaborator

Issue #:
bcgov/entity#25281

Description of changes:
Sev @severinbeauvais, can you change the following please:
VUE_APP_BUSINESS_REGISTRY_URL="op://web-url/$APP_ENV/business-registry-ui/BUSINESS_REGISTRY_URL"

The values are now:
https://dev.business-registry-dashboard.bcregistry.gov.bc.ca/
https://test.business-registry-dashboard.bcregistry.gov.bc.ca/
https://www.business-registry-dashboard.bcregistry.gov.bc.ca/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this Jan 16, 2025
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3209-235llarw.web.app

@severinbeauvais
Copy link
Collaborator

Sev @severinbeauvais, can you change the following please:
VUE_APP_BUSINESS_REGISTRY_URL="op://web-url/$APP_ENV/business-registry-ui/BUSINESS_REGISTRY_URL"

I have updated the 1Password values for this key for Dev, Test and Prod. Please test. Note that most UIs will need to be redeployed to pick up this change. Maybe only sbc-auth/auth-web needs this?

@severinbeauvais
Copy link
Collaborator

Please follow up whether any "account trigger substitution variables" in GCP needs to be upated with the new URL.

@JazzarKarim
Copy link
Collaborator Author

Sev @severinbeauvais, can you change the following please:
VUE_APP_BUSINESS_REGISTRY_URL="op://web-url/$APP_ENV/business-registry-ui/BUSINESS_REGISTRY_URL"

I have updated the 1Password values for this key for Dev, Test and Prod. Please test. Note that most UIs will need to be redeployed to pick up this change. Maybe only sbc-auth/auth-web needs this?

Thanks! Will do. For the time being, only auth-web uses it.

@JazzarKarim JazzarKarim merged commit 919acd5 into bcgov:main Jan 17, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants