Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24658 Implement Staff Search by Filing ID #3186

Merged

Conversation

meawong
Copy link
Collaborator

@meawong meawong commented Dec 19, 2024

*Issue:*bcgov/entity#24658

Description of changes:

  • Added new filings search API call to fetch filing
  • Extend search functionality to accept and handle filingID
  • As per Sev, the code to handle auto-expanding the file does not exist yet in the new Business Dashboard but it will expect the filingID which we are passing as a param in the URL

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@meawong meawong marked this pull request as ready for review December 19, 2024 23:27
@meawong
Copy link
Collaborator Author

meawong commented Dec 19, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3186-89fgsbuz.web.app

@meawong
Copy link
Collaborator Author

meawong commented Dec 19, 2024

Temporary Url for review: https://bcregistry-account-dev--pr-3186-89fgsbuz.web.app

@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3186-89fgsbuz.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pre-approving this PR as I trust you to follow up on the last couple of things.

@meawong
Copy link
Collaborator Author

meawong commented Dec 23, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3186-89fgsbuz.web.app

@severinbeauvais
Copy link
Collaborator

@seeker25 OK if we merge this change?

Also, there's another change coming soon for 24920 to facilitate cutting over from old MBR to new BRD.

For both of these, is there a path forward (ie, release) to go to Test and then Prod?

@seeker25
Copy link
Collaborator

@severinbeauvais yes, ideally not into PROD until the new year though - you should be able to both push to TEST whenever you're ready

@severinbeauvais severinbeauvais merged commit f7aa1c0 into bcgov:main Dec 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants