-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23519 - Change Staff Review Dashboard Continuation Table #3072
23519 - Change Staff Review Dashboard Continuation Table #3072
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
@@ -18,7 +19,7 @@ export interface ContinuationReviewResultIF { | |||
|
|||
/** The Continuation Review API response. */ | |||
export interface ContinuationReviewIF { | |||
completingParty: string | |||
officeEmail: string | |||
creationDate: string // 'YYYY-MM-DDTHH:MM.SS.000+00:00' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gcbrun |
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
Temporary Url for review: https://bcregistry-account-dev--pr-3072-op59dhj8.web.app |
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
@severinbeauvais |
Did you get confirmation on officeEmail? |
Not yet, seems still pending. @severinbeauvais Did you get updates? |
What's the question we need answered? I will ask her directly. |
The changes on registered office email column, changing from completing party to the email address. Are the new designs confirmed? |
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Show resolved
Hide resolved
In the table, the contact information email column should be labelled "Registered Office". There is a policy reason for this. The review page has also been updated (but that's another ticket). |
So I will update line 388 the value to be officeEmail; just for everywhere, update it to be officeEmail |
Signed-off-by: Qin <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge when ready.
Issue #:
bcgov/entity#23519
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).