Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23519 - Change Staff Review Dashboard Continuation Table #3072

Conversation

ArwenQin
Copy link
Contributor

@ArwenQin ArwenQin commented Oct 7, 2024

Issue #:
bcgov/entity#23519

Description of changes:

  • remove code for FED
  • add dot before status
  • adjust the Open/Review Button, remove more action menu
  • handle new "cancelled" status
  • update section headers
  • replace completing party with office email (Registered Office)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@@ -18,7 +19,7 @@ export interface ContinuationReviewResultIF {

/** The Continuation Review API response. */
export interface ContinuationReviewIF {
completingParty: string
officeEmail: string
creationDate: string // 'YYYY-MM-DDTHH:MM.SS.000+00:00'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Design, replace completing party with Registered Office email address:
image
Back end doesn't support this property yet

@severinbeauvais
Copy link
Collaborator

/gcbrun

Signed-off-by: Qin <[email protected]>
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3072-op59dhj8.web.app

@ArwenQin
Copy link
Contributor Author

ArwenQin commented Oct 8, 2024

@severinbeauvais
Just confirmed with Jacqueline, we will keep the more action button for now.

@vysakh-menon-aot
Copy link
Collaborator

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

@ArwenQin
Copy link
Contributor Author

ArwenQin commented Oct 8, 2024

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

@severinbeauvais
Copy link
Collaborator

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

What's the question we need answered? I will ask her directly.

@ArwenQin
Copy link
Contributor Author

ArwenQin commented Oct 8, 2024

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

What's the question we need answered? I will ask her directly.

The changes on registered office email column, changing from completing party to the email address. Are the new designs confirmed?

@severinbeauvais
Copy link
Collaborator

What's the question we need answered? I will ask her directly.

The changes on registered office email column, changing from completing party to the email address. Are the new designs confirmed?

In the table, the contact information email column should be labelled "Registered Office". There is a policy reason for this.

The review page has also been updated (but that's another ticket).

@ArwenQin
Copy link
Contributor Author

ArwenQin commented Oct 8, 2024

So I will update line 388 the value to be officeEmail; just for everywhere, update it to be officeEmail

Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when ready.

@severinbeauvais severinbeauvais merged commit 4b0c899 into bcgov:main Oct 9, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants