22776 - Shortname History Table Fixes #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rodrigo-barraza
approved these changes
Aug 28, 2024
Jxio
approved these changes
Aug 28, 2024
seeker25
reviewed
Aug 28, 2024
| @@ -152,6 +153,7 @@ import { DEFAULT_DATA_OPTIONS } from '../../datatable/resources' | |||
| import { EFTTransactionState } from '@/models/eft-transaction' | |||
| import ModalDialog from '@/components/auth/common/ModalDialog.vue' | |||
| import PaymentService from '@/services/payment.services' | |||
| import { Vue } from 'vue-property-decorator' | |||
There was a problem hiding this comment.
Not too sure why we're introducing this, we're actively trying to get away from using Vue-class-component and vue-property-decorator which are the opposite of composition-api
If you're looking for a Vue instance, you can grab it from another library eg. Vue
There was a problem hiding this comment.
Will fix this in my next PR, as it is another FE ticket.
There was a problem hiding this comment.
all good, I was too slow on the review haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#22776
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).