18258 auth gcp #2973
Merged
18258 auth gcp #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -59,7 +62,7 @@ | |||
| if entity_info: | |||
| entity = Entity(**camelback2snake(entity_info)) | |||
| entity.pass_code = passcode_hash(entity.pass_code) | |||
| current_app.logger.debug(f'Creating entity from dictionary {entity_info}') | |||
| current_app.logger.debug(f"Creating entity from dictionary {entity_info}") | |||
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks Low
pwei1018
requested review from
thorwolpert,
avni-work,
deetz99,
bolyachevets,
sameer0422 and
seeker25
bolyachevets
approved these changes
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
| @@ -12,22 +12,26 @@ LABEL org.label-schema.vcs-ref=${VCS_REF} \ | |||
|
|
|||
| USER root | |||
|
|
|||
| LABEL maintainer="BCROS" | |||
| LABEL maintainer="travissemple" | |||
There was a problem hiding this comment.
keep your name. lol~
seeker25
reviewed
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
seeker25
reviewed
Aug 19, 2024
seeker25
approved these changes
Aug 19, 2024
|
pwei1018
added a commit
to pwei1018/sbc-auth
that referenced
this pull request
Aug 29, 2024
pwei1018
added a commit
to pwei1018/sbc-auth
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#18258
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).