22416 - Update Staff Review Table (Staff Dashboard) #2962
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
|
Updated the date picker's position: |
auth-web/src/components/auth/staff/continuation-application/ContinuationApplicationTable.vue
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2962-1c75zaxm.web.app |
| left: 200%; | ||
| z-index: 1000; | ||
| width: 700px; | ||
| max-width: none; |
There was a problem hiding this comment.
Is this what other uses of the date picker do?
There was a problem hiding this comment.
No, I added these position styles to make the date picker show in the proper position
There was a problem hiding this comment.
Have another look at how the DatePicker is used elsewhere, for example in the TransactionsDataTable. (You'll have to remove the v-if in StaffDashboardView.vue, line 167.) Here's how theirs looks with apparently no special styling:
There was a problem hiding this comment.
There may be some CSS for the above in Transactions.vue (borders and labels).
I think the big difference is that the DatePicker above is outside the data table (so it's anchored differently).
There was a problem hiding this comment.
Thanks! I will update it.
There was a problem hiding this comment.
How about removing the huge top margin?
There was a problem hiding this comment.
Do you mean move it up a little and above the search field?
There was a problem hiding this comment.
That's what I was wondering about. I think the Transactions section does that. It would prevent the date picker from overlapping the next section.
There was a problem hiding this comment.
Does this look better? I will check with Janis too.
There was a problem hiding this comment.
Looks good to me.
Yes, but may seems too long: I saw other uses of the date picker shows "Custom". What do you think? |
Signed-off-by: Qin <[email protected]>
|
|
||
| // The date picker position | ||
| .date-picker { | ||
| left: 40%; |
There was a problem hiding this comment.
Move the date picker to the right
There was a problem hiding this comment.
If you don't do this, is is centered? Ask Janis if centered is ok.
There was a problem hiding this comment.
Yes it's centered, I will confirm with Janis
Ask Janis. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2962-1c75zaxm.web.app |
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2962-1c75zaxm.web.app |
Issue #:
bcgov/entity#22416
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).