Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22686 - MBR Fix Tooltip #2955

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

ArwenQin
Copy link
Contributor

@ArwenQin ArwenQin commented Aug 8, 2024

Issue #:
bcgov/entity#22686

Description of changes:

  • Fix the bug in business type wording for expiration alert
  • Add a tooltip for change requested
  • Updated the FE and Change Requested icon style

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Signed-off-by: Qin <[email protected]>
@ArwenQin
Copy link
Contributor Author

ArwenQin commented Aug 8, 2024

Continuation:
image

Amalgamation:
image

Registration:
image

Change Requested:
image

FE:
image

@severinbeauvais

This comment was marked as resolved.

Signed-off-by: Qin <[email protected]>
@ArwenQin

This comment was marked as outdated.

Signed-off-by: Qin <[email protected]>
maxWidth="300px"
:iconStyling="{'font-size': '1.5em', 'margin-left': '4px'}"
:location="{top: true}"
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For FE icon, default color (Primary), no "Alert:..." needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

image

<strong>Alert:</strong><br>
<span> This application requires you to make changes before resubmitting.</span>
</div>
</IconTooltip>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Requested icon: Added line "Alert:..."
A single line, so no pointer

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "pointer"?

I was thinking about that little triangle at the bottom of the tooltip that points to the icon. And it's there, as it should be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it, sorry, I was thinking about the bullets
image
Bullets are not needed.
It looks good now.

@bcgov bcgov deleted a comment from bcregistry-sre Aug 9, 2024
Signed-off-by: Qin <[email protected]>
Copy link

sonarqubecloud bot commented Aug 9, 2024

@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Aug 9, 2024
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm rebuilding the preview site to verify the icon colour change, and if OK then I'll merge this PR.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2955-g6vjilcu.web.app

@severinbeauvais severinbeauvais merged commit 887a253 into bcgov:main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants