-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22686 - MBR Fix Tooltip #2955
22686 - MBR Fix Tooltip #2955
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
auth-web/src/components/auth/manage-business/AffiliatedEntityTable.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
auth-web/src/components/auth/manage-business/AffiliatedEntityTable.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/manage-business/AffiliatedEntityTable.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
maxWidth="300px" | ||
:iconStyling="{'font-size': '1.5em', 'margin-left': '4px'}" | ||
:location="{top: true}" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For FE icon, default color (Primary), no "Alert:..." needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<strong>Alert:</strong><br> | ||
<span> This application requires you to make changes before resubmitting.</span> | ||
</div> | ||
</IconTooltip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change Requested icon: Added line "Alert:..."
A single line, so no pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "pointer"?
I was thinking about that little triangle at the bottom of the tooltip that points to the icon. And it's there, as it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth-web/src/components/auth/manage-business/AffiliatedEntityTable.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm rebuilding the preview site to verify the icon colour change, and if OK then I'll merge this PR.
Temporary Url for review: https://bcregistry-account-dev--pr-2955-g6vjilcu.web.app |
Issue #:
bcgov/entity#22686
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).