21983 - Enhance Staff Review Table

[ArwenQin]

*Issue #:*21983
bcgov/entity#21983

Description of changes:

• Enabled filtering and sorting for the staff continuation review table
• Filter and sort by all fields
• Pass the params to the API (API doesn't support it for now)
• "Clear Filters" button
• Automatically save filters to user's local storage (and resume)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

[ArwenQin]

[severinbeauvais]

I left a few comments. Overall looks good. Is this all the code changes (other than maybe some extra unit tests)?

[ArwenQin]

I left a few comments. Overall looks good. Is this all the code changes (other than maybe some extra unit tests)?

Yes, these are all the changes. I will fix the issues.

[severinbeauvais]

The UI designs show checkboxes in this menu so that multiple statuses can be selected:

[ArwenQin]

The UI designs show checkboxes in this menu so that multiple statuses can be selected:

Enabled multiple selection for status now:

When more than one status are selected, the display is not good:

Will work on this further, any suggestions?

[severinbeauvais]

Please update the app version :)

[severinbeauvais]

Will work on this further, any suggestions?

https://v2.vuetifyjs.com/en/components/selects/#multiple

[ArwenQin]

Will work on this further, any suggestions?

I didn't look at this deeply but it looks like the list isn't correctly anchored to the dropdown menu...

https://v2.vuetifyjs.com/en/components/selects/#multiple

When multiple statuses are selected, showing "Multiple":

When only one is selected, showing that status:

How about this?

[severinbeauvais]

How about this?

Looks OK to me but double-check with Andy.

[severinbeauvais]

I think the date filter should display a date picker (or 2 date pickers to select a range), and the URL parameters should be in yyyy-mmm-dd format. Did you find any examples that do this? If it's easy, do it in this ticket. Otherwise, create another ticket.

[ArwenQin]

I think the date filter should display a date picker (or 2 date pickers to select a range), and the URL parameters should be in yyyy-mmm-dd format. Did you find any examples that do this? If it's easy, do it in this ticket. Otherwise, create another ticket.

I find an example here:
https://dev.assets.bcregistry.gov.bc.ca/dashboard

May I know which project/file is it in? Thanks!

[severinbeauvais]

May I know which project/file is it in? Thanks!

https://github.com/bcgov/ppr/tree/main/ppr-ui

Look in views/ for the dashboard.

[seeker25]

LGTM

[severinbeauvais]

Arwen, it looks like you want to implement the date filter before this gets merged, right?

[ArwenQin]

Arwen, it looks like you want to implement the date filter before this gets merged, right?

Yes, I'm working on the time picker now :)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[severinbeauvais]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://bcregistry-account-dev--pr-2928-f8q1wi1m.web.app