-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21813 Added Continuation Authorization Review page, route, etc #2894
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <template> | ||
| <header class="v-card-header"> | ||
| <v-icon | ||
| v-if="icon" | ||
| color="bcgovblue2" | ||
| > | ||
| {{ icon }} | ||
| </v-icon> | ||
| <label | ||
| v-if="label" | ||
| class="v-card-label" | ||
| :class="{ 'pl-2': !!icon }" | ||
| > | ||
| {{ label }} | ||
| </label> | ||
| </header> | ||
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| import { Component, Prop, Vue } from 'vue-property-decorator' | ||
|
|
||
| @Component({}) | ||
| export default class CardHeader extends Vue { | ||
| @Prop({ default: null }) readonly icon!: string | ||
| @Prop({ default: null }) readonly label!: string | ||
| } | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| @import '@/assets/styles/theme.scss'; | ||
|
|
||
| .v-card-header { | ||
| display: flex; | ||
| background-color: $BCgovBlue5O; | ||
| padding: 1.25rem; | ||
| border-radius: 4px 4px 0px 0px !important; | ||
|
|
||
| .v-card-label { | ||
| font-weight: bold; | ||
| color: $gray9; | ||
| } | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already added this component with unit tests and everything a while back with unit tests and everything:
https://github.com/bcgov/sbc-auth/blob/main/auth-web/src/components/CardHeader.vue
Keep in mind that my version has extra functionalities/props like a badge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Dunno how I didn't see it.
I'll update this in the follow-on next ticket (bcgov/entity#21815).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Also, I changed the version here to use composition API to stay consistent in AUTH WEB as per a conversation I had with Travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
I believe we're going to have a chat on Monday about moving some stuff out of Auth Web and into a new UI project. That new UI will probably be Nuxt. When we port code over, it can be converted to Composition API.