20463 - Fix: Update Safe Email List on Button Click #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaanjot Gill <[email protected]>
shaangill025
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
|
|
/gcbrun |
seeker25
approved these changes
May 30, 2024
seeker25
reviewed
May 30, 2024
| async function getSafeEmails () { | ||
| // Call to get the email list from the server | ||
| try { | ||
| const response = await StaffService.getSafeEmails() |
There was a problem hiding this comment.
Future: could move these bits to the service itself (200 response check, maybe throw up an error etc). We handle alot of this in the store, probably should be in the service
|
Temporary Url for review: https://bcregistry-account-dev--pr-2847-zi9fdvas.web.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#20463
Description of changes:
Fixes issues with safe email list not displaying after clicking dropdown and re-rendering of the list on addition and removal. Done testing on local env.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).