Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19026 - Implemented the number of businesses ready for D1 dissolution #2831

Merged
merged 8 commits into from
May 22, 2024

Conversation

JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented May 17, 2024

Issue #:
bcgov/entity#19026

Not merging and keeping it as draft for now. The PR endpoint is in review and hasn't been merged yet (bcgov/lear#2683). Should be fine now

Description of changes:

  • Implemented to show the number of businesses that are ready for D1 dissolution

endpoint

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this May 17, 2024
@JazzarKarim JazzarKarim marked this pull request as ready for review May 22, 2024 21:37
@JazzarKarim JazzarKarim force-pushed the 19026-businesses-ready-for-d1 branch from 4bcc2ad to 0fef035 Compare May 22, 2024 21:40
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre May 22, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2831-22c0fofx.web.app

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JazzarKarim JazzarKarim merged commit 06c8641 into bcgov:main May 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants