20929 - Update the involuntary dissolution job via PUT call #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
commented
May 16, 2024
| v-if="isSaving" | ||
| class="loading-container" | ||
| > | ||
| <v-progress-circular |
There was a problem hiding this comment.
This is to prevent the user from spamming the Save button 😆 Basically the component will be replaced by a spinner until the PUT call is done. Logic is below.
JazzarKarim
commented
May 16, 2024
| state.numberOfBusinessesNonEdit = state.numberOfBusinessesEdit | ||
| state.isSaving = true // show the spinner | ||
| // Update store configurations array with the new number of inputted batch size | ||
| staffStore.involuntaryDissolutionConfigurations.configurations.find((config, index) => { |
There was a problem hiding this comment.
This is cleanest way I could think of. Basically finding where the NUM_DISSOLUTIONS_ALLOWED is and changing it's value.
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2829-wz03rzyl.web.app |
JazzarKarim
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
seeker25
reviewed
May 16, 2024
| state.isSaving = true // show the spinner | ||
| // Update store configurations array with the new number of inputted batch size | ||
| staffStore.involuntaryDissolutionConfigurations.configurations.find((config, index) => { | ||
| if (config.name === 'NUM_DISSOLUTIONS_ALLOWED') { |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#20929
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).