20138 - Suspended EFT Account Views #2827
Conversation
|
might be worth adding a unit test or two more.. Also can this be deployed to PROD today? or does it have breaking changes from the existing flows? |
auth-web/src/components/auth/account-freeze/AccountOverview.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/account-freeze/AccountOverview.vue
Outdated
Show resolved
Hide resolved
auth-web/src/util/constants.ts
Outdated
| @@ -114,6 +114,7 @@ export enum AccountStatus { | |||
| PENDING_STAFF_REVIEW = 'PENDING_STAFF_REVIEW', | |||
| PENDING_ACTIVATION = 'PENDING_ACTIVATION', | |||
| NSF_SUSPENDED = 'NSF_SUSPENDED', | |||
| EFT_SUSPENDED = 'EFT_SUSPENDED', | |||
There was a problem hiding this comment.
we're not adding in another code..
Probably just use SUSPENDED I think that's what @Jxio wanted to do?
I was thinking just use NSF_SUSPENDED and then fill in Overdue EFT and NSF PAD payments
But I think if we used NSF_SUSPENDED and SUSPENDED that would work too
There was a problem hiding this comment.
talk to @Jxio about this one
There was a problem hiding this comment.
@Jxio we'll need a status for PAD NSF
Nvm I see what you did now.
There was a problem hiding this comment.
@Jxio the problem with using suspended though, there's an entire flow in sbc-common-components that looks for nsf_suspended and not suspended?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think we only used nsf_suspended for eft currently.
There was a problem hiding this comment.
yeah maybe just use nsf_suspended then, we'll need another field in the suspension_reason_codes to differentiate between PAD NSF and EFT NSF?
auth-web/src/views/auth/account-freeze/AccountSuspendedView.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/account-freeze/AccountOverviewNSF.vue
Outdated
Show resolved
Hide resolved
|
Issue #:
bcgov/entity#20138
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).