20996 Fix MBR after legal name easy fix #2777
Conversation
JazzarKarim
force-pushed
the
20996-fix-mbr-after-legal-name
branch
from
06cd530 to
2e73f4f
Compare
| export interface AffiliationResponse { | ||
| identifier?: string | ||
| draftType?: CorpTypes | ||
| legalType?: CorpTypes | ||
| businessNumber?: string | ||
| name?: string | ||
| legalName?: string | ||
| alternateNames?: AlternateNames[] | ||
| alternateNames?: AlternateNameIF[] |
There was a problem hiding this comment.
Using the latest/updated interface from the shared components repo now.
| @@ -104,7 +97,6 @@ export interface NameRequestResponse { | |||
| natureOfBusiness?: string | |||
| expirationDate?: Date | |||
| nrNum?: string | |||
| requestActionCd?: string | |||
There was a problem hiding this comment.
This is a duplicate of line 96 so I removed it.
auth-web/src/stores/business.ts
Outdated
| @@ -209,6 +209,21 @@ export const useBusinessStore = defineStore('business', () => { | |||
| const entityResponse: AffiliationResponse[] = await OrgService.getAffiliatedEntities(currentOrganization.value.id) | |||
| let affiliatedEntities: Business[] = [] | |||
|
|
|||
| // do a lear search on firms to fetch the latest names (alternate names array) | |||
| // set that array to firm entries in the entityResponse array | |||
| for (const response of entityResponse) { | |||
There was a problem hiding this comment.
Basically, for firms, we need to do a LEAR search to grab that alternateNames array that we need. It's needed to properly display the latest correct name.
There was a problem hiding this comment.
This should be done in the API not on the frontend as a loop?
Or done in one API call not multiple?
There was a problem hiding this comment.
Yeah, was thinking that as well. I'll be doing that.
There was a problem hiding this comment.
Yeah I remember we spent quite a bit of time getting rid of having to call Namex and Legal-api on a per business basis.. it caused alot of performance issues when loading up a dashboard with lets say 100 businesses
Merging this PR would be going in the reverse direction
There was a problem hiding this comment.
As discussed, this https://github.com/bcgov/lear/blob/ce180c3abb996eefd5886def72ddc29620007925/legal-api/src/legal_api/models/business.py#L627
should populate the /search call
There was a problem hiding this comment.
Sounds good, on it
There was a problem hiding this comment.
Removed this entire block Travis, should be OK now.
Search call is now grabbing the alternateNames array (I've made changes in LEAR):
MBR looks good:
| @@ -407,7 +422,7 @@ export const useBusinessStore = defineStore('business', () => { | |||
| return BusinessService.createBNRequest(request) | |||
| } | |||
|
|
|||
| async function searchNRIndex (identifier: string): number { | |||
| async function searchNRIndex (identifier: string): Promise<number> { | |||
There was a problem hiding this comment.
The return type of async must be a Promise.
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2777-b68st5kz.web.app |
JazzarKarim
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
auth-web/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "auth-web", | |||
| "version": "2.5.22", | |||
| "version": "2.5.23", | |||
auth-web/src/models/business.ts
Outdated
| @@ -146,6 +147,6 @@ export interface LearBusiness { | |||
| identifier: string | |||
| legalName: string | |||
| legalType: string | |||
| alternateNames: AlternateNames[] | |||
| alternateNames: AlternateNameIF[] | |||
There was a problem hiding this comment.
So this properties (array) is required here but optional in AffiliationResponse interface?
JazzarKarim
force-pushed
the
20996-fix-mbr-after-legal-name
branch
from
988a48b to
7b3febd
Compare
JazzarKarim
force-pushed
the
20996-fix-mbr-after-legal-name
branch
from
7b3febd to
685234f
Compare
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2777-b68st5kz.web.app |
Issue #:
bcgov/entity#20996
Description of changes:
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).