15310 - text update for continuation in application #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
/gcbrun |
ketaki-deodhar
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
|
Temporary Url for review: https://bcregistry-account-dev--pr-2775-ybj8049b.web.app |
vysakh-menon-aot
approved these changes
Apr 26, 2024
| "removeContinuationInSuccessTitle": "Continuation In Application Deleted", | ||
| "removeContinuationInSuccessText": "You have successfully deleted a continuation in application", | ||
| "removeContinuationInConfirmTitle": "Delete Continuation In Application?", | ||
| "removeContinuationInConfirmText": "Deleting this continuation in application will remove the application from your Business Registry list. If this continuation in was associated with a Name Request, the Name Request can still be used to start a continuation in.", |
There was a problem hiding this comment.
"continuation in" is used twice more in this paragraph. Do those need to be updated?
Generally, did you chat with Yui about all of these and which ones need to be updated?
There was a problem hiding this comment.
I will double check with him
severinbeauvais
approved these changes
Apr 26, 2024
seeker25
approved these changes
Apr 26, 2024
|
Merging this now. I will create another PR if there are any more updates from Yui. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#15310
Description of changes:
supported-continuation-in-entitiesFF works as expectedTemporary Url for review: https://bcregistry-account-dev--pr-2775-ybj8049b.web.app/
Tested this just by flipping the FF value.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).