Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20037 - Fix NSF unlock receipt #2742

Merged
merged 6 commits into from
Feb 28, 2024
Merged

20037 - Fix NSF unlock receipt #2742

merged 6 commits into from
Feb 28, 2024

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#20037

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25 seeker25 changed the title 20037 - Small changes to pass in all the params to generate a receipt 20037 - NSF unlock receipt not working Feb 26, 2024
@seeker25 seeker25 changed the title 20037 - NSF unlock receipt not working 20037 - Fix NSF unlock receipt Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (261dc17) to head (aac49ca).
Report is 249 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   80.71%   78.78%   -1.93%     
==========================================
  Files         322      285      -37     
  Lines       11915    10101    -1814     
  Branches      618      564      -54     
==========================================
- Hits         9617     7958    -1659     
+ Misses       2289     2130     -159     
- Partials        9       13       +4     
Flag Coverage Δ
accountmailerqueue 84.34% <100.00%> (-3.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../account_mailer/email_processors/account_unlock.py 92.30% <100.00%> (ø)
...rvices/account-mailer/src/account_mailer/worker.py 78.19% <100.00%> (-9.79%) ⬇️

... and 159 files with indirect coverage changes

@seeker25 seeker25 marked this pull request as ready for review February 27, 2024 18:00
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25
Copy link
Collaborator Author

seeker25 commented Feb 28, 2024

I'll push these both to DEV and test them out before merging
relies on bcgov/sbc-pay#1429

@seeker25 seeker25 merged commit a11555b into bcgov:main Feb 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants