Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19727 - Query persistence for short names #2728

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:
bcgov/entity#19727

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25
Copy link
Collaborator

/gcbrun

@seeker25 seeker25 marked this pull request as ready for review February 16, 2024 01:47
@seeker25 seeker25 requested review from Jxio and ochiu as code owners February 16, 2024 01:47
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2728-24pg11t7.web.app

@seeker25
Copy link
Collaborator

seeker25 commented Feb 16, 2024

It's remembering the query, but not the tab

image

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix remembering tab, should be good after that

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@seeker25
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2728-24pg11t7.web.app

@seeker25 seeker25 merged commit 31e2041 into bcgov:main Feb 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants