17573/17467: Support for Manufacturer and HomeDealer QS Applicant Reviews #2687
Conversation
cameron-eyds
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
|
/gcbrun |
|
|
Temporary Url for review: https://bcregistry-account-dev--pr-2687-01827awu.web.app |
| * @returns {QualifiedSupplierApplicant} The converted qualified supplier applicant. | ||
| */ | ||
| const formatManufacturer = (mfData: MhrManufacturerInfoIF): QualifiedSupplierApplicant => { | ||
| // Always 1 group with 1 owner in Manufacturer Owner record |
| @@ -236,22 +273,58 @@ export default defineComponent({ | |||
| }), | |||
| qsRequirements: computed((): QualifiedSupplierRequirementsConfig[] => { | |||
| return userAccessRequirements[props.taskDetails?.type] | |||
| }) | |||
| }), | |||
| isLawyerNotaryApplication: computed((): boolean => props.taskDetails?.type === TaskType.MHR_LAWYER_NOTARY), | |||
There was a problem hiding this comment.
cool, I wonder what's the difference between this and
computed<boolean>(()=> props.taskDetails?.type === TaskType.MHR_LAWYER_NOTARY)
There was a problem hiding this comment.
i'm not sure!
It may be a case of either or. Both seem to do the trick.
Do you have a preference? I wonder if one is preferred in a more strict typing scenario 🤔
There was a problem hiding this comment.
either works I think, any feature flags or timing this needs to be released at? or can we just merge and push to prod anytime?
There was a problem hiding this comment.
No feature flags required for this one!
Support to create these Qualified Supplier applications lives on our end and is flagged/unreleased.
This code can go anytime that works for Relationships release schedule 👍
| const orgName = wrapper.find('[data-test="qs-org-name"]').text() | ||
| expect(orgName).toContain('Test Business') | ||
| }) | ||
| it.runIf([TaskType.MHR_MANUFACTURERS, TaskType.MHR_DEALERS].includes(taskType))( |
Issue #:
bcgov/entity#17573
bcgov/entity#17467
Note: Hide White Space changes for easier reviewing 👍
Description of changes:
Home Dealer Applicant Updates:
Manufacturer Applicant Updates:
Fetch and parse data from dedicated Manufacturer endpoint via mhr api
Support for dba name fields, as well as Home/lot location data
Requirements configuration updates
Updated unit tests to verify all types of Qualified Supplier applicants
Some screenshots attached for context:
Home Dealer Flow:
Manufacturer Flow:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).