Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in regex to filter out bad characters for API key generation. #2662

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

seeker25
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2662 (05ddc94) into main (261dc17) will increase coverage by 9.20%.
Report is 178 commits behind head on main.
The diff coverage is 89.53%.

❗ Current head 05ddc94 differs from pull request most recent head d60c371. Consider uploading reports for the commit d60c371 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
+ Coverage   80.71%   89.91%   +9.20%     
==========================================
  Files         322      162     -160     
  Lines       11915     8748    -3167     
  Branches      618        0     -618     
==========================================
- Hits         9617     7866    -1751     
+ Misses       2289      882    -1407     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.91% <89.53%> (-0.05%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
auth-api/src/auth_api/__init__.py 85.33% <100.00%> (ø)
auth-api/src/auth_api/config.py 99.39% <100.00%> (+<0.01%) ⬆️
auth-api/src/auth_api/exceptions/errors.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/affiliation.py 94.82% <100.00%> (+2.14%) ⬆️
auth-api/src/auth_api/models/dataclass.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/membership.py 72.41% <100.00%> (ø)
auth-api/src/auth_api/models/org.py 93.56% <100.00%> (+0.15%) ⬆️
auth-api/src/auth_api/models/product_code.py 96.66% <100.00%> (+0.11%) ⬆️
...th-api/src/auth_api/models/product_subscription.py 100.00% <ø> (ø)
auth-api/src/auth_api/resources/__init__.py 100.00% <100.00%> (ø)
... and 50 more

... and 160 files with indirect coverage changes

@seeker25 seeker25 merged commit 63a83c6 into bcgov:main Dec 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants