Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17534 - New NSF Resource Implementation and NSF Invoice PDF Download #2658

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

*Issue #:17534 *
bcgov/entity#17534

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@rodrigo-barraza rodrigo-barraza marked this pull request as ready for review December 15, 2023 17:06
@ochiu
Copy link
Collaborator

ochiu commented Jan 22, 2024

@rodrigo-barraza looks like we might need another version bump

const calculateFailedInvoices: any = orgStore.calculateFailedInvoices
const downloadNSFInvoicesPDF: any = orgStore.downloadNSFInvoicesPDF
const formatDate = CommonUtils.formatDisplayDate
const suspendedDate = (currentOrganization?.suspendedOn) ? formatDate(new Date(currentOrganization.suspendedOn)) : ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to run into date issues with timezones here, suggestion use Moment instead I think it's already included

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moment(currentOrganization.suspendedOn)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatDate is already a moment instance, so the dates should be fine. formatDate needs to be passed a date object, this is why it's new Date.

emits: ['step-forward'],
setup (_, { emit }) {
const orgStore = useOrgStore()
const currentOrganization: Organization = orgStore.currentOrganization
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these reactive? or does it not matter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved currentOrganization and currentMembership to reactive

@seeker25
Copy link
Collaborator

package.json and package-lock update, then we'll merge

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@seeker25 seeker25 merged commit ea5d9f0 into bcgov:main Jan 22, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants