-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17534 - New NSF Resource Implementation and NSF Invoice PDF Download #2658
Conversation
auth-web/src/components/auth/account-freeze/AccountOverview.vue
Outdated
Show resolved
Hide resolved
|
@rodrigo-barraza looks like we might need another version bump |
const calculateFailedInvoices: any = orgStore.calculateFailedInvoices | ||
const downloadNSFInvoicesPDF: any = orgStore.downloadNSFInvoicesPDF | ||
const formatDate = CommonUtils.formatDisplayDate | ||
const suspendedDate = (currentOrganization?.suspendedOn) ? formatDate(new Date(currentOrganization.suspendedOn)) : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're going to run into date issues with timezones here, suggestion use Moment instead I think it's already included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moment(currentOrganization.suspendedOn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatDate is already a moment instance, so the dates should be fine. formatDate needs to be passed a date object, this is why it's new Date.
emits: ['step-forward'], | ||
setup (_, { emit }) { | ||
const orgStore = useOrgStore() | ||
const currentOrganization: Organization = orgStore.currentOrganization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these reactive? or does it not matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved currentOrganization and currentMembership to reactive
package.json and package-lock update, then we'll merge |
|
*Issue #:17534 *
bcgov/entity#17534
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).