Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18423 - ACCOUNT-MAILER CFS New Requirement Update #2634

Merged

Conversation

AbrahamRostampoor
Copy link
Contributor

Issue #:
bcgov/entity#18423

Description of changes:

  • Updated Account-Mailer CFS Account Number Info

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@AbrahamRostampoor
Copy link
Contributor Author

/gcbrun

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2634 (8e9e293) into main (261dc17) will increase coverage by 3.93%.
Report is 152 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   80.71%   84.64%   +3.93%     
==========================================
  Files         322       16     -306     
  Lines       11915      684   -11231     
  Branches      618       46     -572     
==========================================
- Hits         9617      579    -9038     
+ Misses       2289       93    -2196     
- Partials        9       12       +3     
Flag Coverage Δ
accountmailerqueue 84.64% <ø> (-3.28%) ⬇️
activityloglistenerqueue ?
authapi ?
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 293 files with indirect coverage changes

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2634-qvvprpq2.web.app

@seeker25 seeker25 merged commit e397276 into bcgov:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants