Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17507 - Receipt Creation when NSF Account Paid and Unlocked #2632

Merged
merged 18 commits into from
Jan 22, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #: 17507
bcgov/entity#17507

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@seeker25 seeker25 marked this pull request as ready for review January 22, 2024 22:26
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (261dc17) 80.71% compared to head (5a7c84c) 84.32%.
Report is 192 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
+ Coverage   80.71%   84.32%   +3.61%     
==========================================
  Files         322       17     -305     
  Lines       11915      721   -11194     
  Branches      618       49     -569     
==========================================
- Hits         9617      608    -9009     
+ Misses       2289      100    -2189     
- Partials        9       13       +4     
Flag Coverage Δ
accountmailerqueue 84.32% <ø> (-3.60%) ⬇️
activityloglistenerqueue ?
authapi ?
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 292 files with indirect coverage changes

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging might need to config map logging

@seeker25 seeker25 merged commit 78cdb1a into bcgov:main Jan 22, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants