Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing emit is-pad-valid #2629

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Add missing emit is-pad-valid #2629

merged 4 commits into from
Oct 30, 2023

Conversation

Jxio
Copy link
Collaborator

@Jxio Jxio commented Oct 30, 2023

Issue #:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2629 (fd97c1f) into main (261dc17) will decrease coverage by 80.72%.
Report is 149 commits behind head on main.
The diff coverage is n/a.

❗ Current head fd97c1f differs from pull request most recent head b7d3067. Consider uploading reports for the commit b7d3067 to get more accurate results

@@            Coverage Diff             @@
##             main   #2629       +/-   ##
==========================================
- Coverage   80.71%       0   -80.72%     
==========================================
  Files         322       0      -322     
  Lines       11915       0    -11915     
  Branches      618       0      -618     
==========================================
- Hits         9617       0     -9617     
+ Misses       2289       0     -2289     
+ Partials        9       0        -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi ?
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 301 files with indirect coverage changes

@bcgov bcgov deleted a comment from bcregistry-sre Oct 30, 2023
@Jxio
Copy link
Collaborator Author

Jxio commented Oct 30, 2023

/gcbrun

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2629-u6z7qmo0.web.app

@seeker25 seeker25 merged commit 030df6d into bcgov:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants