17708 - Fixing NEW label status displaying in every page #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-barraza
requested review from
Jxio,
seeker25 and
ochiu
as code owners
|
SonarCloud Quality Gate failed.
|
rodrigo-barraza
commented
Oct 13, 2023
| @@ -249,6 +249,12 @@ export default defineComponent({ | |||
| pageLimit: itemsPerPage | |||
| } | |||
| const getStatementsListResponse = await getStatementsList(filterParams) | |||
|
|
|||
| if ((pageNumber === 1 || !pageNumber) && getStatementsListResponse?.items?.length > 0) { | |||
There was a problem hiding this comment.
Instead of setting the highest ID of the current list as new, we now check to see if the current page we're on in statements is the first (1), or if it has no number at all, before we set the property isNew to the newest statement with the highest ID. This to ensure that when the user switches between pages, that the new label displays as the data loaded, rather than before.
rodrigo-barraza
changed the title
seeker25
approved these changes
Oct 13, 2023
AbrahamRostampoor
pushed a commit
to AbrahamRostampoor/sbc-auth
that referenced
this pull request
Oct 17, 2023
* Refactoring how statement is determined as new * Updating package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #:17708 *
bcgov/entity#17708
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).