Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18051 - Fix unit tests for status-api. #2588

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Oct 3, 2023

bcgov/entity#18051

bcgov/sbc-common-components#335 was fixed as part of this

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@seeker25 seeker25 requested a review from pwei1018 October 3, 2023 18:47
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2588 (029c477) into main (261dc17) will increase coverage by 16.36%.
Report is 125 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2588       +/-   ##
===========================================
+ Coverage   80.71%   97.08%   +16.36%     
===========================================
  Files         322       15      -307     
  Lines       11915      240    -11675     
  Branches      618        0      -618     
===========================================
- Hits         9617      233     -9384     
+ Misses       2289        7     -2282     
+ Partials        9        0        -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi ?
authweb ?
eventlistenerqueue ?
statusapi 97.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 313 files with indirect coverage changes

@seeker25 seeker25 changed the title Fix unit tests for status-api. 18051 - Fix unit tests for status-api. Oct 3, 2023
@seeker25 seeker25 merged commit 180676b into bcgov:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants