Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17708 - Displaying labels beside statements, get total due amount and date #2586

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

rodrigo-barraza
Copy link
Collaborator

@rodrigo-barraza rodrigo-barraza commented Oct 3, 2023

Issue #:17708
bcgov/entity#17708

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

auth-web/src/stores/org.ts Outdated Show resolved Hide resolved
@seeker25
Copy link
Collaborator

seeker25 commented Oct 3, 2023

package json + package lock

@seeker25
Copy link
Collaborator

seeker25 commented Oct 3, 2023

/gcbrun

@seeker25 seeker25 changed the title 17706 - Displaying labels beside statements, get total due amount and date 17708 - Displaying labels beside statements, get total due amount and date Oct 3, 2023
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2586-6r7z1scz.web.app

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.9% 5.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rodrigo-barraza rodrigo-barraza marked this pull request as ready for review October 3, 2023 23:54
Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before SQUASH and Merge: What happens if someone switches their account while on the statements page? Does it reload the statements?

@rodrigo-barraza
Copy link
Collaborator Author

It does indeed reload the statements when switching accounts

@rodrigo-barraza rodrigo-barraza merged commit 4bd5e4a into bcgov:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants