Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17327 & 17856 - Add in overdue to the transactions table & fix status for Online Banking #2578

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Sep 29, 2023

Issue #:
bcgov/entity#17327
bcgov/entity#17856

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25 seeker25 changed the title 17327 - Add in overdue to the transactions table. 17327 & 17856 - Add in overdue to the transactions table & fix status for Online Banking Sep 29, 2023
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@seeker25
Copy link
Collaborator Author

image

Copy link
Collaborator

@rodrigo-barraza rodrigo-barraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@seeker25
Copy link
Collaborator Author

UX provided via screenshots, Ethan made some suggestions and I executed them

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@seeker25 seeker25 merged commit 1db921a into bcgov:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants