17519 - Indicate to user that cancelled/expired NRs will not be returned by NR search #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongjing Chen <[email protected]>
chenhongjing
requested review from
severinbeauvais,
ketaki-deodhar,
JazzarKarim and
leodube-aot
chenhongjing
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -8131,7 +8131,6 @@ | |||
| "version": "1.4.0", | |||
| "inBundle": true, | |||
| "license": "MIT", | |||
| "optional": true, | |||
There was a problem hiding this comment.
Hongjing, what version of Node are you using?
(This is an inconsequential change, but it looks like your "npm i" works differently from whoever updated this file before you.)
severinbeauvais
approved these changes
Sep 25, 2023
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2569-i3s5egvr.web.app |
seeker25
approved these changes
Sep 25, 2023
JazzarKarim
approved these changes
Sep 25, 2023
seeker25
changed the title
|
I reran the tests, probably will pass - Thank you @chenhongjing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#17519
Description of changes:
on My Business Registry Dashboard
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).