Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in status INPROGRESS for a valid status to add an affiliation for a NR #2539

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

seeker25
Copy link
Collaborator

Description of changes:
Allow INPROGRESS to add a valid affiliation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25 seeker25 temporarily deployed to dev September 14, 2023 20:59 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2539 (65d785c) into main (261dc17) will increase coverage by 9.12%.
Report is 59 commits behind head on main.
The diff coverage is 88.49%.

@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
+ Coverage   80.71%   89.83%   +9.12%     
==========================================
  Files         322      162     -160     
  Lines       11915     8617    -3298     
  Branches      618        0     -618     
==========================================
- Hits         9617     7741    -1876     
+ Misses       2289      876    -1413     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.83% <88.49%> (-0.13%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...th-api/src/auth_api/models/product_subscription.py 100.00% <ø> (ø)
...uth-api/src/auth_api/resources/v1/notifications.py 73.91% <73.91%> (ø)
...i/src/auth_api/resources/v1/documents_affidavit.py 80.00% <80.00%> (ø)
auth-api/src/auth_api/resources/v1/org.py 81.93% <81.93%> (ø)
auth-api/src/auth_api/resources/v1/products.py 90.00% <84.61%> (ø)
...-api/src/auth_api/models/affiliation_invitation.py 92.08% <85.41%> (-5.33%) ⬇️
...pi/src/auth_api/services/affiliation_invitation.py 82.60% <86.39%> (-3.17%) ⬇️
auth-api/src/auth_api/resources/v1/invitation.py 86.81% <86.81%> (ø)
auth-api/src/auth_api/resources/v1/task.py 86.88% <86.88%> (ø)
...rc/auth_api/resources/v1/affiliation_invitation.py 87.14% <87.14%> (ø)
... and 38 more

... and 159 files with indirect coverage changes

@seeker25 seeker25 changed the title Add in status INPROGRESS for a valid status to add an affiliation. Add in status INPROGRESS for a valid status to add an affiliation for a NR Sep 14, 2023
@seeker25 seeker25 merged commit 4408a1e into bcgov:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants