Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17528 - Qualified supplier confirmation email #2538

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Sep 14, 2023

Issue #:
bcgov/entity#17528

Description of changes:

  • qualified supplier agreement added to account mailer minio bucket as part of this update
  • implement confirmation email for MHR qualified supplier product subscriptions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2538 (6b8baf0) into main (261dc17) will increase coverage by 8.83%.
Report is 59 commits behind head on main.
The diff coverage is 89.03%.

@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
+ Coverage   80.71%   89.54%   +8.83%     
==========================================
  Files         322      178     -144     
  Lines       11915     9280    -2635     
  Branches      618       41     -577     
==========================================
- Hits         9617     8310    -1307     
+ Misses       2289      962    -1327     
+ Partials        9        8       -1     
Flag Coverage Δ
accountmailerqueue 85.11% <ø> (-2.81%) ⬇️
activityloglistenerqueue ?
authapi 89.87% <89.03%> (-0.09%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...th-api/src/auth_api/models/product_subscription.py 100.00% <ø> (ø)
...uth-api/src/auth_api/resources/v1/notifications.py 73.91% <73.91%> (ø)
...i/src/auth_api/resources/v1/documents_affidavit.py 80.00% <80.00%> (ø)
auth-api/src/auth_api/resources/v1/org.py 81.93% <81.93%> (ø)
auth-api/src/auth_api/resources/v1/products.py 90.00% <84.61%> (ø)
...-api/src/auth_api/models/affiliation_invitation.py 92.08% <85.41%> (-5.33%) ⬇️
...pi/src/auth_api/services/affiliation_invitation.py 82.60% <86.39%> (-3.17%) ⬇️
auth-api/src/auth_api/resources/v1/invitation.py 86.81% <86.81%> (ø)
auth-api/src/auth_api/resources/v1/task.py 86.88% <86.88%> (ø)
...rc/auth_api/resources/v1/affiliation_invitation.py 87.14% <87.14%> (ø)
... and 40 more

... and 146 files with indirect coverage changes

@ochiu ochiu marked this pull request as ready for review September 14, 2023 17:54
@ochiu
Copy link
Collaborator Author

ochiu commented Sep 14, 2023

I added MHR_QualifiedSuppliersAgreement.pdf to dev and test minio buckets. We will need this added for prod.

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeker25 seeker25 merged commit 5657645 into bcgov:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants