17244, 17332, 17246, 17247 - QS Application - Staff Task Review Updates #2529
Conversation
cameron-eyds
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
auth-web/src/components/auth/staff/review-task/QsApplication.vue
Outdated
Show resolved
Hide resolved
cameron-eyds
force-pushed
the
17244-Qs-Staff-Task-Review
branch
from
86eba65 to
abb7196
Compare
|
/gcbrun |
|
SonarCloud Quality Gate failed.
|
|
Sonarcloud is picking up some duplication as a result of a rebase with main. Mostly unit testing and unrelated to this pr 👍 |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2529-7kt9ox6v.web.app |
|
Yup no worries |
|
Is this backwards compatible? Does anything need to be hidden on release? or can we push this to prod easily? we talked and already know the secrets should be there |
| } | ||
|
|
||
| .icon-text { | ||
| display: flex; |
There was a problem hiding this comment.
possible to do inline? using classes?
There was a problem hiding this comment.
Possibly! Will have a look
| @@ -96,6 +104,10 @@ export default class AccountStatusTab extends Vue { | |||
| return this.taskDetails.status === TaskStatus.HOLD | |||
| } | |||
|
|
|||
| private get isTaskRejected (): boolean { | |||
| return this.taskDetails.relationshipStatus === this.TaskRelationshipStatusEnum.REJECTED | |||
There was a problem hiding this comment.
If you're changing these a bit, feel free to convert to composition-api. I know you're busy working on assets stuff though haha.
There was a problem hiding this comment.
I'll have a look, i don't mind!
I believe so yes! |
|
as discussed - Divya will QA this ticket |
seeker25
changed the title
Issue #: /bcgov/entity#17244
Description of changes:
/bcgov/entity#17332
/bcgov/entity#17246
/bcgov/entity#17247
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).