Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9990 - Sentry error for Postal Code field exceeds length #1948

Merged
merged 8 commits into from
May 7, 2022

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented May 4, 2022

Issue #:
bcgov/entity#9990

Description of changes:
Sentry error for Postal Code field exceeds length#9990

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25 seeker25 added the bug Something isn't working label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1948 (47a6f39) into main (b139bc0) will increase coverage by 0.46%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   79.30%   79.76%   +0.46%     
==========================================
  Files         285      300      +15     
  Lines        9832    10419     +587     
  Branches      309      354      +45     
==========================================
+ Hits         7797     8311     +514     
- Misses       2035     2100      +65     
- Partials        0        8       +8     
Flag Coverage Δ
accountmailerqueue 87.77% <100.00%> (?)
activityloglistenerqueue ∅ <ø> (∅)
authapi 90.24% <66.66%> (-0.02%) ⬇️
eventlistenerqueue ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...auth/account-settings/account-info/AccountInfo.vue 54.54% <ø> (ø)
...b/src/components/auth/common/SearchFilterInput.vue 100.00% <ø> (ø)
...nents/auth/create-account/SelectProductService.vue 66.66% <ø> (ø)
...ff/account-management/StaffActiveAccountsTable.vue 100.00% <ø> (ø)
auth-web/src/store/modules/business.ts 18.18% <0.00%> (ø)
...-api/src/auth_api/resources/documents_affidavit.py 82.14% <33.33%> (-3.05%) ⬇️
auth-api/src/auth_api/__init__.py 86.11% <100.00%> (ø)
auth-api/src/auth_api/models/contact.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/services/affiliation.py 90.72% <100.00%> (ø)
...rvices/account-mailer/src/account_mailer/config.py 95.12% <100.00%> (ø)
... and 23 more

@seeker25 seeker25 requested a review from pwei1018 May 4, 2022 20:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit ec0dcfc into bcgov:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants