Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firm Nr Status Bug Fix #1934

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

cameron-eyds
Copy link
Collaborator

*Issue #:11498

Description of changes:

  • Implemented Status check on Firm NRs before allowing Use This Name Request

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Mar 28, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1934 (ce3fdc1) into main (b139bc0) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   79.30%   79.29%   -0.01%     
==========================================
  Files         285      285              
  Lines        9832     9833       +1     
  Branches      309      311       +2     
==========================================
  Hits         7797     7797              
- Misses       2035     2036       +1     
Flag Coverage Δ
authweb 44.17% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/src/components/auth/common/SearchFilterInput.vue 100.00% <ø> (ø)
...ff/account-management/StaffActiveAccountsTable.vue 100.00% <ø> (ø)
auth-web/src/store/modules/business.ts 18.04% <0.00%> (-0.14%) ⬇️
auth-api/src/auth_api/services/affiliation.py 90.72% <100.00%> (ø)

@cameron-eyds cameron-eyds requested review from severinbeauvais and vysakh-menon and removed request for vysakh-menon March 28, 2022 16:47
@cameron-eyds cameron-eyds merged commit 40650ad into bcgov:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants