Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SP & GP #1921

Merged
merged 1 commit into from
Mar 7, 2022
Merged

added SP & GP #1921

merged 1 commit into from
Mar 7, 2022

Conversation

saravanpa-aot
Copy link
Contributor

Issue #:

bcgov/entity#9251

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@saravanpa-aot saravanpa-aot added the enhancement New feature or request label Mar 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1921 (a57699d) into main (15adb5e) will increase coverage by 0.01%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   79.87%   79.88%   +0.01%     
==========================================
  Files         277      277              
  Lines        9655     9656       +1     
  Branches      449      449              
==========================================
+ Hits         7712     7714       +2     
+ Misses       1943     1942       -1     
Flag Coverage Δ
authapi 90.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth-api/src/auth_api/services/user_settings.py 94.73% <ø> (ø)
...account-settings/payment/AccountPaymentMethods.vue 63.63% <0.00%> (ø)
...auth/account-settings/transaction/Transactions.vue 100.00% <ø> (ø)
...-web/src/components/auth/common/PaymentMethods.vue 100.00% <ø> (ø)
...web/src/components/auth/home/NameRequestButton.vue 100.00% <ø> (ø)
...nts/auth/manage-business/AffiliatedEntityTable.vue 12.50% <0.00%> (ø)
...mponents/auth/manage-business/EntityManagement.vue 50.00% <ø> (ø)
auth-web/src/store/modules/staff.ts 32.89% <0.00%> (ø)
auth-web/src/views/auth/home/RequestNameView.vue 50.00% <ø> (ø)
...uth-web/src/views/auth/staff/ReviewAccountView.vue 58.33% <ø> (ø)
... and 16 more

@pwei1018 pwei1018 merged commit d7b8a8b into bcgov:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants