Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing find visible affiliations logic #1903

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

sumesh-aot
Copy link
Contributor

@sumesh-aot sumesh-aot commented Jan 31, 2022

Issue #:
bcgov/entity#10737

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1903 (15adb5e) into main (ee31e15) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
- Coverage   80.22%   79.87%   -0.36%     
==========================================
  Files         292      277      -15     
  Lines       10221     9655     -566     
  Branches      494      449      -45     
==========================================
- Hits         8200     7712     -488     
+ Misses       2013     1943      -70     
+ Partials        8        0       -8     
Flag Coverage Δ
accountmailerqueue ?
authapi 90.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth-api/src/auth_api/services/affiliation.py 90.72% <100.00%> (+0.06%) ⬆️
auth-api/src/auth_api/utils/enums.py 100.00% <100.00%> (ø)
...es/account-mailer/src/account_mailer/auth_utils.py
...ervices/account-mailer/src/account_mailer/utils.py
...ccount_mailer/email_processors/pad_confirmation.py
...rc/account_mailer/services/notification_service.py
...rvices/account-mailer/src/account_mailer/config.py
...rvices/account-mailer/src/account_mailer/worker.py
...ailer/src/account_mailer/services/minio_service.py
...ccount_mailer/email_processors/refund_requested.py
... and 7 more

@sumesh-aot sumesh-aot merged commit 746e858 into bcgov:main Jan 31, 2022
@sumesh-aot sumesh-aot deleted the 10851 branch January 31, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants